Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D DeepPavlov
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DeepPavlov
  • DeepPavlov
  • Merge requests
  • !972

fix: nn_trainer, don't treat initial validation results as score improvement

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andrei Glinskii requested to merge github/fork/Huawei-MRC-OSI/clear_saved into master Aug 16, 2019
  • Overview 28
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: grwlf

Change from this PR allows nn_trainer to save model on existing from train function correclty. We assume that model saving shouldn't be ignored if its parameters were changed since the time of previous save. Since chainer.train_on_batch changes parameters, we need to mark the model as 'dirty'.

Previous version of DP didn't clear _saved flag at all. As a result, the trainer didn't save the last version of model if its save method was called at some point during or before training, e.g. in _validate_first mode.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Huawei-MRC-OSI/clear_saved