Fix/kbqa

Created by: dmitrijeuseew

resolving #883 (closed)

deeppavlov/configs/ner/ner_kb_rus.json

 {
   "dataset_reader": {
     "class_name": "sq_reader",
-    "data_path": "/home/dmitry/download/ner_ontonotes"
+    "data_path": "{DOWNLOADS_PATH}/ner_sq/SQ_rus_dataset_zs.pckl"
   },
   "dataset_iterator": {
     "class_name": "data_learning_iterator"
@@ -149,7 +149,7 @@
     "variables": {
       "ROOT_PATH": "~/.deeppavlov",
       "DOWNLOADS_PATH": "{ROOT_PATH}/downloads",
-      "MODELS_PATH": "{ROOT_PATH}/models/kbqa"
+      "MODELS_PATH": "{ROOT_PATH}/models/ner_sq"
     },
     "requirements": [
       "{DEEPPAVLOV_PATH}/requirements/fasttext.txt",
@@ -167,6 +167,10 @@
       {
         "url": "http://files.deeppavlov.ai/embeddings/lenta_lower_100.bin",
         "subdir": "{DOWNLOADS_PATH}/embeddings"
+      },
+      {
+        "url": "http://files.deeppavlov.ai/datasets/SQ_rus_dataset_zs.pckl",
+        "subdir": "{DOWNLOADS_PATH}/ner_sq"
       }
     ]
   }

deeppavlov/dataset_readers/kbqa_reader.py

+# Copyright 2017 Neural Networks and Deep Learning lab, MIPT
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 from pathlib import Path
 
 from deeppavlov.core.common.registry import register
@@ -14,7 +28,7 @@ class KBQAReader(DatasetReader):
         files = list(data_path.glob('*.txt'))
         test_set_filename = "test_set_with_answers.txt"
         if test_set_filename not in {file_path.name for file_path in files}:
-            url = 'http://files.deeppavlov.ai/kbqa/test_set_with_answers.txt'
+            url = 'http://files.deeppavlov.ai/kbqa/test_set_with_answers.zip'
             data_path.mkdir(exist_ok=True, parents=True)
             download_decompress(url, data_path)
         dataset = {}

deeppavlov/dataset_readers/sq_reader.py

+# Copyright 2017 Neural Networks and Deep Learning lab, MIPT
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from pathlib import Path
+import pickle
+
+from deeppavlov.core.data.dataset_reader import DatasetReader
+from deeppavlov.core.data.utils import download
+from deeppavlov.core.common.registry import register
+
+
+@register('sq_reader')
+class OntonotesReader(DatasetReader):
+    """Class to read training datasets in OntoNotes format"""
+
+    def read(self, data_path: str):
+        with open(data_path, 'rb') as f:
+            dataset = pickle.load(f)
+
+        return dataset

[Andrei Glinskii]

Created by: yoptar

Are you sure that you don't need to change any code in the sq_reader after changing data_path format?

[Andrei Glinskii]

Created by: StrikerRUS

Where sq_reader can be found? GitHub search gives nothing: https://github.com/deepmipt/DeepPavlov/search?q=sq_reader+path:/deeppavlov/dataset_readers&unscoped_q=sq_reader+path:/deeppavlov/dataset_readers

[Andrei Glinskii]

Created by: yoptar

Thank you, @StrikerRUS for noticing! It's in this pull request now.

[Andrei Glinskii]

Created by: StrikerRUS

Thanks for fixing this!