Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D DeepPavlov
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DeepPavlov
  • DeepPavlov
  • Merge requests
  • !1170

[wip][debug]Refactor/go bot

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Andrei Glinskii requested to merge refactor/go_bot_debug into master Apr 05, 2020
  • Overview 1
  • Commits 56
  • Pipelines 0
  • Changes 15

Created by: oserikov

An early work-in-progress PR on the refactoring of the GO-bot.
Looking for the architecture review: see the main script go_bot.py (the refactored version of the old network.py).

NLU, NLG, text2vec and features engineering are moved to the separate classes. Some helping dto-like classes are introduced.

Requires more testing to ensure that the ML logic is preserved without errors.

What is done:

  • moved the NLU logic to the separate unit.
  • moved the NLG logic to the separate unit.
  • moved the text 2 vectors encoding logic to the separate unit.
  • moved the complicated NN configs parsing to the separate class to ease further refactoring and simplification.

Todo:

  • testing and debugging. Last commit is probably worsening the metrics for some reason.
  • reorder the commits to smth meaningful and informative. This pr is opened from the debug branch, commits are overtracing the modifications to analyze metrics.
  • More intuitive features, targets and batches classes.
  • Proper OOP patterns for state tracker and multiple users tracking mechanism.
  • Proper naming of things.
  • Logging
  • Type-hinting, docstrings etc
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: refactor/go_bot_debug